New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental support for post processors #7568
Conversation
🦋 Changeset detectedLatest commit: 38b3bcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
postProcess
that allows modifying lint resultpostProcess
that allows modifying lint result
postProcess
that allows modifying lint resultpostProcessor
that allows modifying lint result
postProcessor
that allows modifying lint resultpostProcessor
that allows modifying lint results
postProcessor
that allows modifying lint resultsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YuanboXue-Amber Thanks for the pull request. Can you take a look at my comments?
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@ybiquitous Do you refer to the example in the configure.md file? I've updated the example there. It is now more aligned with our specific use case, the reason why we needed this feature. Let me know your thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! The implementation is overall good 👍🏼
Can you take a look at my some suggestions?
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Thank you :) I addressed all comments. Appreciate another round of review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
@ybiquitous thank you and could you merge this? I don't have access. Also when will be the next release 🛳️? |
I will merge this after waiting for other reviews in a few days. |
Since there are no concerns or objections, I'm merging this PR. And I'll release the next minor version soon. @YuanboXue-Amber Again, thank you for the contribution! |
Thank you @ybiquitous. Looking forward! |
Closes #7567
Adding experimental config
processors
that allows modifying lintresults
object:Type:
Usage:
In config:
JSON:
or multiple processors:
Example processor: