-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor utilities to unify parseSelector()
and parseSelectorAST()
#7647
Conversation
This unifies similar utilities using `postcss-selector-parser` into one. The new utility returns a root object for selectors.
|
}); | ||
}); | ||
|
||
if (context.fix && fixedSelector) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note
stylelint/lib/rules/selector-not-notation/__tests__/index.mjs
Lines 35 to 36 in 713f36f
code: ':not(:not()) {}', | |
unfixable: true, |
could potentially return ''
if it ever was supported.
expect(selectorRoot).toHaveProperty('nodes[0].nodes[0].value', 'a'); | ||
}); | ||
|
||
expect(typeof processed).toBe('string'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note
jest-extended has toBeString
Thanks for the review 👍🏼 |
stylelint#7647) This unifies similar utilities using `postcss-selector-parser` into one. The new utility returns a root object for selectors.
None.
This unifies similar utilities using
postcss-selector-parser
into one. The new utility returns a root object for selectors.Tip
I recommend ignoring whitespace changes for code review.