Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor utilities to unify parseSelector() and parseSelectorAST() #7647

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 24, 2024

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

This unifies similar utilities using postcss-selector-parser into one. The new utility returns a root object for selectors.

Tip

I recommend ignoring whitespace changes for code review.

This unifies similar utilities using `postcss-selector-parser` into one.
The new utility returns a root object for selectors.
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 713f36f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review April 24, 2024 16:43
});
});

if (context.fix && fixedSelector) {
Copy link
Member

@Mouvedia Mouvedia Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

code: ':not(:not()) {}',
unfixable: true,

could potentially return '' if it ever was supported.

expect(selectorRoot).toHaveProperty('nodes[0].nodes[0].value', 'a');
});

expect(typeof processed).toBe('string');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note

jest-extended has toBeString

@ybiquitous
Copy link
Member Author

Thanks for the review 👍🏼

@ybiquitous ybiquitous merged commit 8c23fce into main Apr 25, 2024
17 checks passed
@ybiquitous ybiquitous deleted the refactor-parseSelector-util branch April 25, 2024 12:39
emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024
stylelint#7647)

This unifies similar utilities using `postcss-selector-parser` into one.
The new utility returns a root object for selectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants