Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function-calc-no-unspaced-operator false negatives #7655

Merged
merged 14 commits into from
May 8, 2024
Merged

Fix function-calc-no-unspaced-operator false negatives #7655

merged 14 commits into from
May 8, 2024

Commits on Apr 26, 2024

  1. Fix function-calc-no-unspaced-operator false negatives 

    This significantly changes the implementation by switching `postcss-value-parser` to `@csstools/css-parser-algorithms`.
Because `postcss-value-parser` is inactive and leaves bugs for a while,
and we've used already `@csstools/css-parser-algorithms` for some rules.

In addition, this updates `tsconfig.json` to support ES2023 libraries.
This change uses `Array.prototype.findLast()`, which has been supported since Node.js 18.0.0.
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findLast
    @ybiquitous
    ybiquitous committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b673910 View commit details
    Browse the repository at this point in the history

  2. Refactor to extract isBefore local variable

    @ybiquitous
    ybiquitous committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a422005 View commit details
    Browse the repository at this point in the history

  3. Refactor to simplify isScssInterpolation()

    @ybiquitous
    ybiquitous committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ab9ae27 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Add support for multi-argument functions to `function-calc-no-unspace… 

    …d-operator` (#7670)
    @romainmenke
    romainmenke committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5dc44b2 View commit details
    Browse the repository at this point in the history

  2. Add changelog entry for #7618

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d1d0f6d View commit details
    Browse the repository at this point in the history

  3. Clarify changelog description

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ba9ef7a View commit details
    Browse the repository at this point in the history

  4. Remove no longer needed calcKeywords reference

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4f4b8e7 View commit details
    Browse the repository at this point in the history

  5. Refactor to use forEach over traditional for-loop

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    14848bf View commit details
    Browse the repository at this point in the history

  6. Refactor to clarify variable name

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1d2f997 View commit details
    Browse the repository at this point in the history

  7. Refactor to clarify variable names by new type guards

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b7bd1e2 View commit details
    Browse the repository at this point in the history

  8. Update description for function-calc-no-unspaced-operator rule

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a4c2707 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into function-calc-no-unspaced-operator-bugfix

    @ybiquitous
    ybiquitous committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4055b41 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix function-calc-no-unspaced-operator unit and ident escaping (#7676)

    @romainmenke
    romainmenke committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a8304d3 View commit details
    Browse the repository at this point in the history

  2. Refactor to reduce repetition of `isWhitespaceNode(currentNode) || is… 

    …CommentNode(currentNode)`
    @ybiquitous
    ybiquitous committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c8d7979 View commit details
    Browse the repository at this point in the history