Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump micromatch from 4.0.5 to 4.0.7 #7712

Merged
merged 1 commit into from
May 24, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 24, 2024

Bumps micromatch from 4.0.5 to 4.0.7.

Commits
Maintainer changes

This version was pushed to npm by paulmillr, a new releaser for micromatch since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.7.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.7)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the pr: dependencies relates to dependencies label May 24, 2024
Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 40fe18b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ybiquitous
ybiquitous previously approved these changes May 24, 2024
@Mouvedia
Copy link
Member

This one is important.

see micromatch/braces#37 (comment) and micromatch/micromatch@4.0.5...4.0.7#diff-7ae45ad102

@ybiquitous ybiquitous self-requested a review May 24, 2024 11:59
@ybiquitous ybiquitous dismissed their stale review May 24, 2024 11:59

Be careful to bump.

@ybiquitous
Copy link
Member

@Mouvedia Thanks. I'll dig into them.

@ybiquitous
Copy link
Member

I think this update is not a problem because braces@<3.0.3 has a vulnerability (see https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727). I can locally confirm that only braces@3.0.3 is present in our dependency tree. ✅

$ npm ls braces
stylelint@16.6.0 /Users/masafumi.koba/git/stylelint/stylelint
├─┬ lint-staged@15.2.2
│ └─┬ micromatch@4.0.5
│   └── braces@3.0.3 deduped
├─┬ micromatch@4.0.7
│ └── braces@3.0.3
└─┬ remark-cli@12.0.1
  └─┬ unified-args@11.0.0
    └─┬ chokidar@3.5.3
      └── braces@3.0.3 deduped

@ybiquitous
Copy link
Member

Actually, there is only a change to update a dependency braces from ^3.0.2 to ^3.0.3 with micromatch/micromatch@9cc27cc.

$ npm diff --diff-name-only --diff micromatch@4.0.5 --diff micromatch@4.0.7
package.json
README.md

@Mouvedia If you still have concerns, feel free to comment.

@ybiquitous ybiquitous merged commit 5f366b6 into main May 24, 2024
17 checks passed
@ybiquitous ybiquitous deleted the dependabot/npm_and_yarn/micromatch-4.0.7 branch May 24, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: dependencies relates to dependencies
Development

Successfully merging this pull request may close these issues.

None yet

2 participants