Add url secondary option to any rules

[emmacharp]

Which issue, if any, is this issue related to?

Closes #7484

Is there anything in the PR that needs further explanation?

Based on @ybiquitous implementation proposal here. Additional changes were made to lintSource.mjs and validateOptions.mjs as to prevent undefined errors and invalid option warnings. customUrls property was added to checkAgainstRule.mjs as to pass certain tests.

[changeset-bot]

🦋 Changeset detected

Latest commit: 8170609

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ybiquitous]

@emmacharp Thanks for the pull request! First of all, you can fix the system test failures by running the command:

npx jest system-tests --updateSnapshot

[ybiquitous]

[suggest] We should add a new section for url under the rules section in the documentation:
https://github.com/stylelint/stylelint/blob/9a2e6540f92509628df76032262293ae57d32dda/docs/user-guide/configure.md#rules

[ybiquitous]

[ask] @emmacharp Just to be sure, how will you specifically configure your rules when this url option is released?
I'm just wondering if you need the function support as described on #7484 (comment).

[emmacharp]

@ybiquitous, I do not see the need for function support as of now.

[emmacharp]

npx jest system-tests --updateSnapshot

This command is giving me errors. For instance:

 SyntaxError: Cannot use import statement outside a module
   at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)

Any idea why?

[ybiquitous]

Hum, I've never seen this error SyntaxError: Cannot use import statement outside a module ... 🤔

I might be wrong, but it seems due to environmental issues. Here's my environment (macOS latest)

$ node -v && npm -v
v22.2.0
10.8.1

And the clean installation and updating Jest snapshots work for me.

$ npm ci
...
$ npx jest system-tests --updateSnapshot
...
$ git status
On branch custom_urls
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   system-tests/002/__snapshots__/fs.test.mjs.snap
	modified:   system-tests/002/__snapshots__/no-fs.test.mjs.snap
	modified:   system-tests/003/__snapshots__/fs.test.mjs.snap
	modified:   system-tests/003/__snapshots__/no-fs.test.mjs.snap
	modified:   system-tests/004/__snapshots__/fs.test.mjs.snap
	modified:   system-tests/004/__snapshots__/no-fs.test.mjs.snap
	modified:   system-tests/005/__snapshots__/commonjs.test.cjs.snap

no changes added to commit (use "git add" and/or "git commit -a")

[ybiquitous]

[suggest] Can you add a new test file named lib/__tests__/standalone-custom-url.mjs to test this new feature? If you prefer another file name, you may take it.

[emmacharp]

I've been able to run jest by following the second option here:
https://jestjs.io/docs/ecmascript-modules

[ybiquitous]

Oh, I forgot about --experimental-vm-modules 😅

stylelint/package.json

Line 77 in 7a78847

"test": "node --experimental-vm-modules node_modules/jest/bin/jest.js",

So, we should run Jest like this (of course, NODE_ENV is also available):

npm run test --ignore-scripts -- --updateSnapshot system-tests/

[emmacharp]

[suggest] Can you add a new test file named lib/__tests__/standalone-custom-url.mjs to test this new feature? If you prefer another file name, you may take it.

I'm not really familiar with these kinds of test but I'll give it a shot and report back!

[ybiquitous]

This test file might be helpful: 👇🏼
https://github.com/stylelint/stylelint/blob/3bdb897f647b776973abd630114141f96990c2e6/lib/__tests__/standalone-quiet.test.mjs

If you find it too hard, feel free to ask for help. If you don't mind, I can also do that instead of you. 😃

[emmacharp]

Reporting back!

I've created a test file here which seems to work as intended. Still new to Jest so I hope it really is. Hehe.

[ybiquitous]

Thank you! LGTM 👍🏼

[Mouvedia]

@ybiquitous, I do not see the need for function support as of now.

The only use case that I can see would be to dynamically change the anchor/fragment.
This can be postponed.