Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute plugin path in configs #913

Merged
merged 1 commit into from
Mar 12, 2016

Conversation

Arcanemagus
Copy link
Contributor

There were some instances where a plugin could be specified by name, and end up not being resolved as a later merge of extended configs would drop the fixed path.

I'm not sure of the best way to write a spec for this, as this will only show up when a module name is used for the plugin, where currently all the specs seem to test relative paths.

This was originally reported by @davidtheclark over here, which provides a nice setup of how to expose this issue.

There were some isntances where a plugin could be specified by name, and end up not being resolved as a later merge of extended configs would drop the fixed path.
@davidtheclark
Copy link
Contributor

@Arcanemagus: Thanks so much for looking into this. And good job figuring out that subtle problem.

We already have an outstanding issue to improve integration tests (#569) so I'm happy to just consider tests for this to be part of that effort and merge this.

Thanks again. Good catch.

davidtheclark added a commit that referenced this pull request Mar 12, 2016
Use absolute plugin path in configs
@davidtheclark davidtheclark merged commit 9b66986 into stylelint:master Mar 12, 2016
@davidtheclark
Copy link
Contributor

It was tricky to figure out the way to test that this worked in my Atom editor, but I think I confirmed :)

@ismay
Copy link
Contributor

ismay commented Mar 17, 2016

This hasn't been released yet right? Is there a patch release planned? Because right now this crashes atom when using stylelint-selector-bem-pattern and I'd love to see this merged.

@davidtheclark
Copy link
Contributor

I will release a patch tonight. Sorry.

On Thu, Mar 17, 2016 at 11:23 AM, Ismay notifications@github.com wrote:

This hasn't been released yet right? Is there a patch release planned,
because right now this crashes atom when using
stylelint-selector-bem-pattern.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#913 (comment)

@ismay
Copy link
Contributor

ismay commented Mar 17, 2016

@davidtheclark No problem at all, just wondering :). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants