Use absolute plugin path in configs #913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some instances where a plugin could be specified by name, and end up not being resolved as a later merge of extended configs would drop the fixed path.
I'm not sure of the best way to write a spec for this, as this will only show up when a module name is used for the plugin, where currently all the specs seem to test relative paths.
This was originally reported by @davidtheclark over here, which provides a nice setup of how to expose this issue.