-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested tagged template literals aren't being ignored by --fix #218
Comments
This seems to have been a prettier issue rather than a stylelint issue. I'm still trying to get to the root of it, but once I ran |
Reopening this issue as it has started to act up again. I've identified that this is related to this issue. I'm using stylelint 13.13.1, so it seems like the parser isn't always ignoring the pattern. I did manage to get it to ignore the pattern for a bit, but after another day or so and it's acting up again with no clear path to satisfying it. Is there a safe way for me to tell stylelint parser to ignore this pattern in this instance?
|
vscode-stylelint doesn't contribute any fixes itself, Stylelint does all of the fixing/formatting. I know that there is an umbrella issue over at the main Stylelint repository tracking CSS-in-JS issues: stylelint/stylelint#4574. If this issue can be reliably reproduced only in vscode-stylelint and not Stylelint itself, feel free to reopen this issue. Otherwise, I think the linked Stylelint issue may be a good starting point to see if this is a problem that's already been noted or if a new issue needs to be opened at the Stylelint repository. I saw another issue there about nested tagged template literals, but I'm not certain it's the same issue you're experiencing: stylelint/stylelint#4119. |
Just wanted to leave an update here that it seems like the latest update has resolved this issue with no special action taken on my part. |
When using Styled Componenets and saving the following, the stylelint autofix results in broken code:
It is omitting the final
}
causing the code to break. Is there some way I can audit what rules run on save to perhaps identify the conflicting styelint rule?e.g.
Yes
0.86.0
13.13.1
Yes, it's related to passing props into a Styled Componenet
For the stylelint to not format away my closing bracket.
No warnings or errors.
The text was updated successfully, but these errors were encountered: