Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document formatter to use dynamic registration #241

Closed
adalinesimonian opened this issue Sep 29, 2021 · 2 comments · Fixed by #251
Closed

Update document formatter to use dynamic registration #241

adalinesimonian opened this issue Sep 29, 2021 · 2 comments · Fixed by #251
Assignees
@adalinesimonian
Labels
type: refactor an improvement to the code structure

Comments

@adalinesimonian
Copy link
Member

adalinesimonian commented Sep 29, 2021 •
edited
Loading

See #200 (comment), API docs

Related: #110

Using dynamic registration would decouple the language server's formatting support from the extension.
@adalinesimonian adalinesimonian added type: refactor an improvement to the code structure status: ready to implement is ready to be worked on by someone labels Sep 29, 2021
@adalinesimonian adalinesimonian mentioned this issue Sep 29, 2021
Merged
@rchl
Copy link
Contributor

rchl commented Sep 29, 2021

Also link to the client/registerCapability request - https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#client_registerCapability

adalinesimonian added a commit that referenced this issue Oct 4, 2021
@adalinesimonian
fix: don't register document formatter twice
f05e589 
Fixes #250, Closes #241

Replaces extension's formatter registration implementation with server-
side dynamic or static registration, depending on client capabilities.
@adalinesimonian adalinesimonian mentioned this issue Oct 4, 2021
Merged
@adalinesimonian adalinesimonian self-assigned this Oct 4, 2021
@adalinesimonian adalinesimonian added status: wip is being worked on by someone and removed status: ready to implement is ready to be worked on by someone labels Oct 4, 2021
@adalinesimonian
Copy link
Member Author

adalinesimonian commented Oct 4, 2021 •
edited
Loading

In #250, a bug was identified wherein a duplicate document formatter would be registered. Since I had to touch the formatting code anyway to prepare a fix, I implemented dynamic registration in #251.

adalinesimonian added a commit that referenced this issue Oct 4, 2021
@adalinesimonian
fix: don't register document formatter twice (#251)
3e75b02 
Fixes #250, Closes #241

Replaces extension's formatter registration implementation with server-
side dynamic or static registration, depending on client capabilities.
@adalinesimonian adalinesimonian removed the status: wip is being worked on by someone label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adalinesimonian adalinesimonian

Labels
type: refactor an improvement to the code structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't register document formatter twice stylelint/vscode-stylelint
2 participants
@rchl @adalinesimonian