Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebrand — Option C, update description, keep existing logo #305

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Rebrand — Option C, update description, keep existing logo #305

merged 1 commit into from
Nov 8, 2021

Conversation

adalinesimonian
Copy link
Member

Closes #288

  • Description updated to "Official Stylelint extension for Visual Studio Code"

@adalinesimonian adalinesimonian added this to the v1.1.0 milestone Nov 1, 2021
@adalinesimonian adalinesimonian self-assigned this Nov 1, 2021
@adalinesimonian adalinesimonian added this to In progress in Rolling Work Tracking via automation Nov 1, 2021
@adalinesimonian adalinesimonian moved this from In progress to Review in progress in Rolling Work Tracking Nov 1, 2021
@adalinesimonian adalinesimonian mentioned this pull request Nov 1, 2021
Closed
Rolling Work Tracking automation moved this from Review in progress to Reviewer approved Nov 3, 2021
ota-meshi
ota-meshi approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like this option. However, other options are ok.

@adalinesimonian adalinesimonian modified the milestones: v1.1.0, v1.2.0 Nov 6, 2021
@adalinesimonian adalinesimonian changed the base branch from main to v1.2 November 6, 2021 21:43
@adalinesimonian adalinesimonian added this to Reviewer approved in v1.2 Nov 6, 2021
ntwb
ntwb approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also going to suggest this option, this gets the verbiage change in asap, we can then revisit the logo design changes as a follow up

@adalinesimonian
Copy link
Member Author

I'm also going to suggest this option, this gets the verbiage change in asap, we can then revisit the logo design changes as a follow up

I'm on board with this. I'll merge this in and keep the other two PRs open

@adalinesimonian adalinesimonian merged commit b47a70b into v1.2 Nov 8, 2021
@adalinesimonian adalinesimonian deleted the 288-only-description branch November 8, 2021 17:13
Rolling Work Tracking automation moved this from Reviewer approved to Done Nov 8, 2021
v1.2 automation moved this from Reviewer approved to Done Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

@jeddy3 jeddy3 Awaiting requested review from jeddy3

Assignees

@adalinesimonian adalinesimonian

Labels
None yet
Projects
Rolling Work Tracking
Done
v1.2
  
Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Update description (and maybe icon?)
3 participants
@adalinesimonian @ntwb @ota-meshi