Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly serialize errors sent to logger #310

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

adalinesimonian
Copy link
Member

@adalinesimonian adalinesimonian commented Nov 3, 2021

Encountered in #281

Prior to this fix, in certain instances, logged errors would be missing critical information, such as message or stack.

Example, prior to fix:

[Debug - 9:24:33 a.m.] [language-server] Log message | error: {}

Example, after fix:

[Debug - 9:24:33 a.m.] [language-server] Log message | error: {"name":"Error","message":"…","stack":"…"}

Prior to this fix, in certain instances, logged errors would be missing
critical information, such as `message` or `stack`.
@adalinesimonian adalinesimonian added this to the v1.1.0 milestone Nov 3, 2021
@adalinesimonian adalinesimonian self-assigned this Nov 3, 2021
@adalinesimonian adalinesimonian added this to In progress in Rolling Work Tracking via automation Nov 3, 2021
@adalinesimonian adalinesimonian moved this from In progress to Review in progress in Rolling Work Tracking Nov 3, 2021
@adalinesimonian adalinesimonian merged commit cc0536c into main Nov 4, 2021
@adalinesimonian adalinesimonian deleted the serialize-errors branch November 4, 2021 20:30
Rolling Work Tracking automation moved this from Review in progress to Done Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant