Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rule doc URL #375

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix: fix rule doc URL #375

merged 2 commits into from
Feb 9, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Feb 9, 2022

Which issue, if any, is this issue related to?

Closes #377

Is there anything in the PR that needs further explanation?

Since Stylelint 14.3.0, meta.url has been added:
https://github.com/stylelint/stylelint/blob/14.3.0/CHANGELOG.md#1430

Also, this change updates the stylelint package via npm i stylelint.

Since Stylelint 14.3.0, `meta.url` has been added:
<https://github.com/stylelint/stylelint/blob/14.3.0/CHANGELOG.md#1430>

Also, this change updates the `stylelint` package via `npm i stylelint`.
@ybiquitous ybiquitous marked this pull request as ready for review February 9, 2022 06:22
@ybiquitous

This comment was marked as resolved.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ybiquitous
Copy link
Member Author

@ota-meshi Thank you for the review. 👍🏼

How will the release of a new version be performed? Is it possible for you to handle the release?

@ota-meshi
Copy link
Member

Is it possible for you to handle the release?

I seem to be unable to access the 1password vault 😅.

Perhaps you can just update the version and publish using vsce to release it.

https://code.visualstudio.com/api/working-with-extensions/publishing-extension

@ybiquitous
Copy link
Member Author

I see. Let's wait a while for the previous releaser.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not very familiar with the code base.

I suggest we merge and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rule function-no-unknown not found in docs
3 participants