Dim toolbar icon on unstyled tabs #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,19 +12,21 @@ function webNavigationListener(method, data) { | |||
| return; | |||
| } | |||
| getStyles({matchUrl: data.url, enabled: true, asHash: true}, function(styleHash) { | |||
| chrome.tabs.sendMessage(data.tabId, {method: method, styles: styleHash}); | |||
| // Don't show the badge for frames | |||
| if (data.frameId == 0 && prefs.getPref("show-badge")) { | |||
There was a problem hiding this comment.
data.frameId is 0 here because of line 11/12.
|
I've put the logo source at https://userstyles.org/newlogo.xcf . Not sure if that's helpful at this point. |
|
To create the svg I've previously used the 128px icon (which is slightly distorted) as a source, so now I've fixed a few discrepancies using the real source and realigned all the icons on pixel grid. |
|
It works inconsistently when enabling a style on the new tab page. |
|
|
Rebased on master. |
|
With two tabs and one global style:
|
Works because Chrome *overlays* user-specified badge color onto its own default color.
|
Fixed, hopefully. |
JasonBarnabe
added a commit
that referenced
this pull request
May 21, 2015
Dim toolbar icon on unstyled tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
Sremains the same, bg = 20%, outer border = 50% opacity. Transparent background should look good on non-bright themes, supposedly, unlike 100% white bg that would have been brighter than the default bg.in disableAll mode the icon is also dimmed, style count badge is displayed on a lightgray background #aaa - should we have an option to customize this color to make it look good with dark themes?
The default 19x19 icon was recreated using SVG vector source:
Sand its outline were straightened a bit (check it out using GitHub's "Swipe" preview mode in diff)38x38 retina-aware icons were added. Not tested.
All icons were compressed with
pngquant --quality 50-80Default icon blinks for an instant here (usually less than 0.1s) when I navigate a styled site, this is what happens:
updateIcon: OK(particularly wacky when you navigate from an unstyled page to a styled one)
updateIcon: OKThe whim part apparently is incurable as there's nothing between onBeforeNavigate & onCommitted:
Although we can leave the colored icon as default in manifest.json and not care about it being incorrect on about:blank and other chrome:// pages except for Edit and Manage.
Other extensions are updating their icons after ~1 second or so, which makes them look not too smart in comparison.