Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when opening and closing chrome windows #286

Open
Fanolian opened this issue Aug 19, 2016 · 1 comment
Open

Memory leak when opening and closing chrome windows #286

Fanolian opened this issue Aug 19, 2016 · 1 comment

Comments

@Fanolian
Copy link

Fanolian commented Aug 19, 2016

Firefox environment: 32bit Firefox 48 (e10s disabled) or current Nightly (e10s enabled/disabled)

Steps to reproduce:

  1. Install Stylish 2.0.7 in a new profile. Restart browser.
  2. Without creating/installing any styles, open one tab and only in one window. Go to about:memory.
  3. Minimize memory usage a few times then measure a verbose report.
  4. Search for "detached" (without quote) in about:memory. It should have no detached windows at this point.
  5. Open a new window or a new private window, then close it.
  6. Go back to about:memory, minimize memory usage and measure again. a top(none)/detached/window(chrome://browser/content/browser.xul)/dom/event-listeners is created.
  7. Repeat step 5 and 6 a few times. More top(none)/detached/… are created and cannot be destroyed unless restarting browser.

It is not a recent regression. I think I've seen it for a very long time.

Note:
Other chrome windows may leak too, e.g. Library window(chrome://browser/content/places/places.xul)

P.S.
Traditional extensions (non-jetpack/WebExtensions) like Greasemonkey and Tree Style Tabs [1] had similar issues for a long time too but fixed eventually. They may provide hints on why Stylish leaks.

[1]: For Tree Style Tabs, search for commits around 2015-11-06 to 2015-11-10 for relevant fixes:
piroor/treestyletab@9516999...000ce6b

Thank you for your extension.

Update: add commit range for Tree Style Tabs

@Fanolian
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant