Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font color is black #245

Closed
Yakarup opened this issue Oct 19, 2023 · 12 comments
Closed

font color is black #245

Yakarup opened this issue Oct 19, 2023 · 12 comments
Labels
bug 🐛 Something isn't working

Comments

@Yakarup
Copy link

Yakarup commented Oct 19, 2023

On default settings, except for the background image - Random Tile. I've reinstalled the style. Answer font colors are black. Post vote counts (scores) are black. Original post font color is black. Am using latest version v5.1.2

  • Browser: Google Chrome Version 117.0.5938.134 (Official Build) (64-bit)
  • Operating System: Windows 10 x64 Version 10.0.19045 Build 19045
  • Link to page with the issue: Everywhere across all stackexchange networks/sub-stackexchanges
  • Screenshot:
    Capture
@Yakarup Yakarup added the bug 🐛 Something isn't working label Oct 19, 2023
@SmartManoj
Copy link

SmartManoj commented Oct 20, 2023

dirty fix

p, .js-vote-count, body  {
            color: #ddd !important;
}

@haxj
Copy link

haxj commented Oct 20, 2023

Dirty fix, improved:

Add

  p, .js-vote-count, body, pre, code {
    color: var(--highlight-color) !important;
  }
  pre, code {
    background: var(--highlight-bg) !important;
  }

and change the following

    --highlight-bg: var(--black-200) !important;
    --highlight-color: var(--fc-dark);

to

    --highlight-bg: #181818 !important;
    --highlight-color: #ddd !important;

@muru
Copy link

muru commented Oct 21, 2023

Not a fix since this can't be done using user CSS, but using Greasemonkey or the like to add theme-dark to the body element's classes works remarkably well:

document.getElementsByTagName('body')[0].classList.add('theme-dark')

It works so well that some problematic areas like diffs in the revision history of posts appear better than before. (the actual colours might not be to your taste, but at least they're readable now).

@Yakarup
Copy link
Author

Yakarup commented Oct 22, 2023

I also want to mention that only stackoverflow is unaffected. Otherwise, yeah, the font color is black on every stackexchange network.

@SylwesterZarebski
Copy link
Contributor

As a quick fix I've inserted before line 67:

		--theme-body-font-color: /*[[strong-color]]*/;

@SylwesterZarebski
Copy link
Contributor

PR created. I've checked multiples SE sites, no more black text.

awebeer256 added a commit to awebeer256/StackOverflow-Dark that referenced this issue Nov 13, 2023
@mpeter50
Copy link

@SylwesterZarebski 's solution is already much better, but @muru 's solution also fixes the code blocks' background color!
Thank you both for your solutions!

@SylwesterZarebski
Copy link
Contributor

@mpeter50 : Can You provide a link with wrong code blocks bg colours? I would check it.

@mpeter50
Copy link

Here is an example: https://superuser.com/questions/1613852/how-do-i-run-a-sudo-command-on-a-remote-machine-using-ssh

This is how it looks for me with your fix (no userscript, repo's userstyle edited by adding --theme-body-font-color: /*[[strong-color]]*/; after line 66):

image

This is how it looks without editing the userstyle, but with the userscript:

image

@muru
Copy link

muru commented Nov 21, 2023

@mpeter50 it looks like you're not using the StackOverflow Syntax Themes usercss. Check the README, it's "a required additional style".

@mpeter50
Copy link

Oh, thats right, thanks for pointing that out! I have now installed that style and this way its ok with this modification, without a userscript.

This way inline code blocks are less visually distinct than before, but after tweaking the settings of the syntax style a little its better then before! Just jotting it down in case anyone will find it useful.

@Yakarup
Copy link
Author

Yakarup commented Dec 4, 2023

Bug fixed by commit e53dd43

@Yakarup Yakarup closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants