Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixing causes flexbox to be set outside media query #291

Open
jakobdamjensen opened this issue Nov 19, 2014 · 3 comments
Open

Prefixing causes flexbox to be set outside media query #291

jakobdamjensen opened this issue Nov 19, 2014 · 3 comments

Comments

@jakobdamjensen
Copy link

The following gives incorrect output:

.footer__navigation {
  border-bottom: 1px solid $brown;
  overflow: hidden;
  padding: 30px 0;

  +above($m) {
    display: flex;
    justify-content: center;
    margin: 0 auto;
    max-width: $m;
  }
}

Output =

.footer__navigation {
  border-bottom: 1px solid #9b8c89;
  overflow: hidden;
  padding: 30px 0;
  display: -webkit-box;
  display: -webkit-flex;
}
@media screen and (min-width: 600px) {
  .footer__navigation {
    display: -ms-flexbox;
    display: box;
    display: flex;
    -webkit-box-pack: center;
    -webkit-justify-content: center;
    justify-content: center;
    margin: 0 auto;
    max-width: 600px;
  }
}

Notice how

display: -webkit-box;
display: -webkit-flex;

Is set on .footer__navigation.

This is done with the latest version on npm (nib@1.0.4)

@chuckharmston
Copy link

I'm experiencing this problem as well.

@arecvlohe
Copy link

same here

@jamesplease
Copy link

jamesplease commented May 18, 2016

Yikes...1.5 years and this is still an issue... @slang800, are you available to review a PR if I try to figure this out?


For future visitors, if your browser support is pretty decent you should try out #312 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants