Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper background-size keyword support #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artnez
Copy link
Contributor

@artnez artnez commented Jul 10, 2013

Prevents the background-size property from being ignored for non-retina
screens.

@artnez
Copy link
Contributor Author

artnez commented Jul 10, 2013

I tried to avoid a "private" mixin at first (nib-image--background-size), but duplicating the logic that generates background-size seemed worse.

Here's a quick (untested) example that illustrates the scoping issue:

mymixin(someargument = 'defaultvalue')
  someargument = 'anothervalue' // we override someargument, but it does not bleed into the nested scope below
  someproperty someargument
  @media blah
    someproperty someargument

body
  mymixin()

// .. produces something like ..

body {
  someproperty: 'anothervalue';
}
@media blah {
  body {
    someproperty: 'defaultvalue';
  }
}

Prevents the background-size property from being ignored for non-retina
screens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant