Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: make css package be optional #2707

Closed
wants to merge 2 commits into from
Closed

deps: make css package be optional #2707

wants to merge 2 commits into from

Conversation

iChenLei
Copy link
Member

@iChenLei iChenLei commented Jul 16, 2022 •
edited

What:

Try to fix #2665

Why:

angular/angular-cli#22748 and more community feedback

How:

Make css be optional package deps.

Checklist:

  • Documentation
  • Unit Tests
  • Code complete
  • Changelog

@iChenLei
Copy link
Member Author

cc @ota-meshi @groenroos Any suggestion ?

@holblin
Copy link
Contributor

holblin commented Aug 5, 2022

I will do a PR to use https://www.npmjs.com/package/@adobe/css-tools.
That will solve the issue ;-)

@holblin
Copy link
Contributor

holblin commented Aug 5, 2022

See: #2709

@iChenLei iChenLei mentioned this pull request Aug 13, 2022
Merged
4 tasks
@iChenLei iChenLei closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning source-map-resolve
2 participants
@iChenLei @holblin