Organise fakers into categories

[boardfish]

Right now, these categories are somewhat minimal and could be expanded. For example, something like Faker::Movies::HarryPotter should arguably be in some Books module instead as the book series has greater influence than the movies. However, this adds some consistency overall that I felt necessary.

I'm aware that two tests are failing but I haven't been able to pinpoint why that is. If a maintainer is able to pull my fork and assist with this, I'd very much appreciate it.

I intend to follow up this PR at some point to fix some pre-existing spelling/grammar issues across the project, most noticeable with flaws such as stranger_thing.rb, but I figured they'd be outside the scope of this one.

This PR is related to this issue #1318.

[vbrazo]

Thanks for submitting this PR 👍

I see that you're adding a few namespaces and that's pretty helpful. We started the discussion on this issue and we still have a lot of work to do.

I have a few considerations:

• You're adding namespaces for Games, but we already have a PR for the Games namespace that covers all the objects. So I'd suggest removing the Games changes. If you want to collaborate, take a look at the PR, read the changes and let the contributor know your considerations.
• I saw that you also created namespaces for movies, tv, anime, comics. I'd prefer to have these namespaces in separate PRs. The title of the PRs should be something like:
  Add Faker::Movies namespace
Add Faker::Tv namespace
Add Faker::Comics namespace
Add Faker::Anime namespace
• What's the difference between tv and movies? tv is for TvShows?
• If you're removing a method, you need to deprecate the old method. So I'd advice you not to delete the old object and deprecate its methods. Otherwise when we release the PR, users will start having crashes in their systems. You can find an example here.

[boardfish]

Gotcha. I think I went a little bit ham on this one — the inconsistency on namespaces really stuck out to me, so it'd be good if PRs relating to this can be merged soon. I'll close this one, but I'll likely make a few others as you say to break things down more. I'll probably do Anime first as that doesn't encompass much right now but could be likely to grow, as potential for My Hero Academia and similarly expansive media to be included is pretty strong.

With regards to deprecation, what's a good reference on how to handle that in this report? Is there another PR that's done it in a way you'd like to see as the standard?

[vbrazo]

@boardfish sounds good. You can start with Faker::Anime. You can also discuss namespaces in that open issue #1318. Our current challenge is to define good taxonomy and your suggestions would be pretty awesome. We enjoy discussing with the community to understand what they like and dislike, because at the end of the day they'll use the gem.

Check this PR #1264 out. In this example, we deprecated Faker::Name.title in the version 1.9.1 (current version), because we'd already added Faker::Job.title in a previous PR, and we noticed that we had two methods that were doing the same thing.

In version 1.9.1, Faker::Name.title and Faker::Job.title work, but if you use Faker::Name.title, you should receive a warning message, because in the next version we're going to remove Faker::Name.title. This is good because it avoids crashes and unhappy users coming here to open issues complaining about life. We usually release a new version 2-3 times a year to make sure that everyone is warned.

To deprecate a method, you just need to add extend Gem::Deprecate to the class and add a deprecate method: deprecate :title, 'Faker::Job.title', 2018, 9.

Feel free to contribute by adding namespaces or new objects. We're always happy to see new PRs :)