Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new array of cities from brazil #1443

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Conversation

WilliamCSA04
Copy link
Contributor

I have added an array of cities from brazil to pt-BR.yml to get a real city when run Faker::Address.city if locale is pt-BR.

@WilliamCSA04 WilliamCSA04 changed the title Add new a array of cities from brazil Add new array of cities from brazil Oct 24, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this .yml and adding all the cities 👍

Braziiil 🇧🇷 ❤️

@vbrazo vbrazo merged commit 0a9d802 into faker-ruby:master Oct 26, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Added brazilian cities to pt-BR.yml

* Changed test pt br address methods to fit new cities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants