Add lorempixel image support #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def
to
a5d7731
Compare
vbrazo
reviewed
May 27, 2018
There was a problem hiding this comment.
I think this Image object looks pretty similar to a few modules that we have:
- https://github.com/stympy/faker/blob/master/doc/lorem_flickr.md
- https://github.com/stympy/faker/blob/master/doc/lorem_pixel.md
What do you think?
vbrazo
reviewed
Jul 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nice to have an ability to create sample image links that are not avatars. I found the lorempixel site that provides just that.
Any feedback is welcomed, I hope these changes are worth merging =).