Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend in check to more value types #85

Closed
anderseknert opened this issue Apr 11, 2023 · 0 comments · Fixed by #87
Closed

Extend in check to more value types #85

anderseknert opened this issue Apr 11, 2023 · 0 comments · Fixed by #87
Labels
bug Something isn't working

Comments

@anderseknert
Copy link
Member

As pointed out by @charlieegan3, we could check for more types than string + var in the "prefer in over iteration" rule.
@anderseknert anderseknert added the bug Something isn't working label Apr 11, 2023
anderseknert added a commit that referenced this issue Apr 11, 2023
@anderseknert
Extend "in" check to any datatype
549bb3f 
Tests only for LHS, as it felt redundant to check for both 😅

Fixes #85

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue Apr 11, 2023
Merged
anderseknert added a commit that referenced this issue Apr 11, 2023
@anderseknert
Extend "in" check to any datatype
94218e3 
Tests only for LHS, as it felt redundant to check for both 😅

Fixes #85

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Apr 12, 2023
@anderseknert
Extend "in" check to any datatype (#87)
3c6ee58 
Tests only for LHS, as it felt redundant to check for both 😅

Fixes #85

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend "in" check to any datatype StyraInc/regal
1 participant
@anderseknert