Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1670 Fix race condition when DFP is enabled and there is a disappearing viewcontroller #227

Merged
merged 1 commit into from
May 9, 2024

Conversation

jhaven-stytch
Copy link
Collaborator

Linear Ticket: LINEAR_NUMBER

Changes:

  1. Inject the webview into the root viewcontroller, instead of the topmost
  2. make sure that we remove the webview after completing the flow

Notes:

  • Validated in workbench

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

… that we _remove_ the webview after completing the flow
@jhaven-stytch jhaven-stytch force-pushed the jordan/SDK-1670-oauth-dfp-race-condition branch from 3d9a8f1 to cd17d08 Compare May 9, 2024 14:05
@jhaven-stytch jhaven-stytch merged commit 2842949 into main May 9, 2024
7 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1670-oauth-dfp-race-condition branch May 9, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants