Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes styxlab/next-cms-ghost#6 #10

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Fixes styxlab/next-cms-ghost#6 #10

merged 2 commits into from
Dec 29, 2020

Conversation

akshatmittal
Copy link
Contributor

@akshatmittal akshatmittal commented Dec 29, 2020

Properly shows 404 page for non-existent pages now. Also switches to blocking fallback to send 404 status directly from the server, it can be disabled for pure UI based 404, but that's not recommended for SEO reasons.

image

@vercel
Copy link

vercel bot commented Dec 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styxlab/next-cms-ghost/8kpwfzyj1
✅ Preview: https://next-cms-ghost-git-fork-akshatmittal-master.styxlab.vercel.app

minor styling: we prefer single quotes here
@styxlab
Copy link
Owner

styxlab commented Dec 29, 2020

@akshatmittal: Thanks a lot for this nice bug fix! It works like a charm!

@styxlab styxlab merged commit 8e2984c into styxlab:master Dec 29, 2020
@akshatmittal
Copy link
Contributor Author

@styxlab Glad I could help, great work btw!

@styxlab
Copy link
Owner

styxlab commented Jan 8, 2021

@all-contributors please add @akshatmittal for code

@allcontributors
Copy link
Contributor

@styxlab

I've put up a pull request to add @akshatmittal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants