Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): fix Windows normalize bug #4

Closed
wants to merge 1 commit into from

Conversation

mtaberna
Copy link
Contributor

The use of normalize function from Node library in Windows return
unexpected backslash when normalizing slug. The use of normalize library
should be completely removed, as a hot fix I added the slash library to
revert Windows backslash.

The use of normalize function from Node library in Windows return
unexpected backslash when normalizing slug. The use of normalize library
should be completely removed, as a hot fix I added the slash library to
revert Windows backslash.
@vercel
Copy link

vercel bot commented Dec 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styxlab/next-cms-ghost/r07unbyr5
✅ Preview: https://next-cms-ghost-git-fork-beatplus-master.styxlab.vercel.app

@styxlab
Copy link
Owner

styxlab commented Dec 26, 2020

Closing this PR as I am not (yet) ready to support native Windows, If you use Windows, the recommended way is to use this repo on WSL (Windows subsystem for Linux). If anyone wants to make this repo fit for native Windows, I am open to looking into any new proposals, but I will require the following prerequisites:

  1. Identify all code places that are potentially broken on native Windows
  2. Research into whether problems can be fixed upstream or with standard packages, to keep any windows specific code to the minimum (ideally all packages work on Windows as well)
  3. Design some specific tests for Windows, so future problem can be detected early on

Please open a new issue if you want to discuss or continue working on native Windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants