Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改訂履歴更新 #328

Merged
merged 3 commits into from
Jul 30, 2022
Merged

改訂履歴更新 #328

merged 3 commits into from
Jul 30, 2022

Conversation

jollyjoester
Copy link
Contributor

2022-06-06更新分を追加

Closes #248

@jollyjoester
Copy link
Contributor Author

@stzn 遅くなりました!レビューをお願いします!

質問です!
Localでの確認 or GitHub pagesのbranchでの確認ってどうされてますか?別ページのセクションのリンクが合っているかを動作確認したいのですが、うまい方法を知らず🤔

Copy link
Owner

@stzn stzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!僕はVSCodeのプレビューをクリックして確認してますね。GitHub pagesブランチはmainから自動マージしているのでmainが正しければ正しいとしています。(何か間違っていたらご指摘ください😅)

revision-history/document-revision-history.md Outdated Show resolved Hide resolved
revision-history/document-revision-history.md Outdated Show resolved Hide resolved
jollyjoester and others added 2 commits July 30, 2022 01:40
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
@jollyjoester
Copy link
Contributor Author

了解です!
提案もありがとうございます。取り込みました!

Copy link
Owner

@stzn stzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです👍🏻ありがとうございます!もう少し他の方の意見がないか様子見てからマージしたいと思います。

@jollyjoester
Copy link
Contributor Author

はい!

@stzn stzn merged commit db91225 into stzn:master Jul 30, 2022
@jollyjoester jollyjoester deleted the update-revision-history branch August 7, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

改訂履歴更新
2 participants