-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionalの説明改善 #461
Optionalの説明改善 #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
セルフレビュー
ありがとうございます! |
いつでも大丈夫です! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます。ほとんどLGTMです。
一部細かいコメントをしています。主に既存の記載でも表記ゆれの問題があり、それに関する修正です。(「オプショナル」「オプショナルの値」を「オプショナル値」に統一など)
ここら辺の表現方法は悩んでいるところもあるので、もしご意見あればいただけると嬉しいですmm
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
問題ないと思います! しかし、「オプショナルの値」と表記されている箇所が何点か見受けられます。 参考
the-swift-programming-language-jp/language-guide/automatic-reference-counting.md Line 177 in b9e0d15
the-swift-programming-language-jp/language-guide/automatic-reference-counting.md Line 420 in b9e0d15
また、「オプショナル値」となっている箇所もあります。 the-swift-programming-language-jp/language-guide/automatic-reference-counting.md Line 374 in b9e0d15
|
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
いくつか追加したいところがあったのでコメントしています。お時間のある時にご確認ください🙇🏻♂️(全然急がなくて大丈夫です!)
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
@stzn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
色々とご対応ありがとうございます!
最後に既存のコードでいくつか修正したいところがあったので提案をしています🙇🏻♂️
そこに問題なければ取り込んでください。その後マージします。
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
Co-authored-by: shiz <35151927+stzn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!大丈夫だと思うのでマージしますね!
Closes #433
タイトルとIssueの通りです。
参考元のPRは日本時間8月31日にマージされました。
参考:apple/swift-book#143