Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on wall distance calculation from symmetry plane of mesh deformation #1200

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

Nicola-Fonzi
Copy link
Contributor

Proposed Changes

In the calculation of the stiffness for the mesh deformation, if the symmetry plane for the deformation is too stiff, cells may get distorted and the simulation may crash.

This occurred when the wall distance stiffness was used, and the symmetry plane for the deformation was also a solid wall boundary. This small fix should avoid the issue.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@Nicola-Fonzi Nicola-Fonzi marked this pull request as draft February 17, 2021 09:32
@pcarruscag pcarruscag added this to In progress in General Maintenance via automation Feb 17, 2021
@Nicola-Fonzi Nicola-Fonzi marked this pull request as ready for review February 17, 2021 11:01
@Nicola-Fonzi Nicola-Fonzi merged commit 42bb167 into develop Feb 17, 2021
General Maintenance automation moved this from In progress to Done Feb 17, 2021
@Nicola-Fonzi Nicola-Fonzi deleted the fix_stiffness_deformSymPlane branch February 17, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants