-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes / cleanup of CONV_CRITERIA which has no effect and will be deprecated in 7.2.0 #1238
Conversation
…are cleaned in next commit.
Common/src/CConfig.cpp
Outdated
if (!option_name.compare("CONV_CRITERIA")) | ||
newString.append("CONV_CRITERIA is deprecated.\n\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dammmm really?! I guess if something is a residual it uses the residual criteria (criterion?) and if it is a coefficient it uses Cauchy?
Mind throwing that in the message? This is another one that will break every config...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. In COutput::Convergence_Monitoring there is a distinction for CONV_FIELD
between HistoryFieldType::COEFFICIENT
and HistoryFieldType::RESIDUAL
.
I'll add that information to the error msg 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually... do you think we should give folks a pass and just print a warning (with that exact message) and say that we will deprecate in the future? When we go to 7.2.0 (which could happen soon if we merge the hybrid parallel AD and the Scalar solvers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that also requires readding the option. I'll try to remember to enforce that for 7.2.0
edit: ah and the optionMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I made it a warning but as it is thrown at config parsing in Postprocessing I guess not lot of people will see it anyway.
I guess one can git revert aa7393f
at some point in the future.
And CONV_CRITERIA is a stringOption so one can type in there whatever one likes :) no optionMap required
@@ -173,7 +173,7 @@ void CMultizoneDriver::StartSolver() { | |||
if (rank == MASTER_NODE){ | |||
cout << endl <<"Simulation Run using the Multizone Driver" << endl; | |||
if (driver_config->GetTime_Domain()) | |||
cout << "The simulation will run for " << driver_config->GetnTime_Iter() << " time steps." << endl; | |||
cout << "The simulation will run until time step " << driver_config->GetnTime_Iter() << "." << endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SingleZoneDriver nTimeIter - Restart_Iter
can lead to underflow of the unsigned long result which is now checked in CConfig
Thanks for the approval! 🦃 |
Proposed Changes
PR Checklist