Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: temporary config filename #1576

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

ArneVoss
Copy link
Member

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Using the python interface to modify the config file, it may happen that the temporary config file is accessed at once by multiple SU2 runs, leading to io conflicts. Thus, the name of the temporary file should not be hard-coded. This bugfix simply adds a '_tmp' to the original config file name.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

by multiple SU2 runs, leading to io conflicts. Thus, the name of the
temporary file should not be hard-coded. This bugfix simply adds a
'_tmp' to the original config file name.
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@pcarruscag
Copy link
Member

Ah wait, special thanks, since it is your first contribution, add yourself to AUTHORS.md please.

@pcarruscag pcarruscag added this to In progress in General Maintenance via automation Mar 23, 2022
Adding my name :)
@ArneVoss
Copy link
Member Author

Ah wait, special thanks, since it is your first contribution, add yourself to AUTHORS.md please.

That's an honor, thank you!

@pcarruscag pcarruscag merged commit 4934e14 into su2code:develop Mar 24, 2022
General Maintenance automation moved this from In progress to Done Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants