Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing phase angle in calculation of grid velocity for rigid pitching motion #1656

Merged
merged 3 commits into from
Jun 4, 2022

Conversation

HL-ZHI
Copy link
Contributor

@HL-ZHI HL-ZHI commented Jun 4, 2022

Proposed Changes

For RIGID_PITCHING movement, add PHASE parameter to angular velocities.

Pitching angle: angle=Ampl * sin(Omega * Time + Phase)
Original augular velocity: AlphaDot = Omega * Ampl * cos(Omega *Time)
Updated angular velocity: AlphaDot = Omega * Ampl * cos(Omega *Time + Phase)

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pcarruscag pcarruscag changed the base branch from master to develop June 4, 2022 09:38
@pcarruscag pcarruscag changed the title Update CVolumetricMovement.cpp Fix missing phase angle in calculation of grid velocity for rigid pitching motion Jun 4, 2022
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@pcarruscag
Copy link
Member

I forgot, please add yourself (either name or GitHub handle) to the AUTHORS.md file (alphabetical order).

@HL-ZHI
Copy link
Contributor Author

HL-ZHI commented Jun 4, 2022

I forgot, please add yourself (either name or GitHub handle) to the AUTHORS.md file (alphabetical order).

Done. #1657

@pcarruscag pcarruscag merged commit 0232486 into su2code:develop Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants