Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1667 Potential crash for the OpenMP multi-thread running. #1678

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

lcheng9
Copy link
Contributor

@lcheng9 lcheng9 commented Jun 21, 2022

Proposed Changes

Initialize the omp_partitions vector with the number of points, skip the for loop if the last partition has been calculated. A light-weight checker is added also to verify the partition vector, promote a warning or error message if necessary.

Related Work

Fix #1667 Potential crash for the OpenMP multi-thread running.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Initialize the omp_partitions vector with the number of points, skip the for loop if the last partition has been calculated. A light-weight checker is added to verify the validation of the partition vector.
Common/src/linear_algebra/CSysMatrix.cpp Outdated Show resolved Hide resolved
@pcarruscag
Copy link
Member

Thank you for opening a PR, please add yourself to AUTHORS.md (note that it is in a funny alphabetical order with upper case before lower case)

@lcheng9
Copy link
Contributor Author

lcheng9 commented Jun 21, 2022

Thanks for the approval. I will update the AUTHORS.md next time together with other changes.

@pcarruscag pcarruscag merged commit eed1e67 into su2code:develop Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants