Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile SU2 with Mutation++ for regression tests #1935

Merged
merged 20 commits into from
Aug 20, 2023
Merged

Conversation

WallyMaier
Copy link
Contributor

Proposed Changes

This updates the version of MPP for use in the NEMO solver.

Is there a way to include a MPP test case for the regressions?

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • [?] I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pr-triage pr-triage bot added the PR: draft label Feb 22, 2023
@WallyMaier
Copy link
Contributor Author

I think this is correct. I updated the SHA and checked the mutation++ submodule to version said SHA-Tag.

@WallyMaier WallyMaier changed the title [WIP]Update Mutation++ Version Update Mutation++ Version Feb 22, 2023
@WallyMaier WallyMaier marked this pull request as ready for review February 22, 2023 17:02
@pcarruscag
Copy link
Member

Try changing regression.yml to compile with Mutation and we'll see if we need to update the docker images.

@WallyMaier
Copy link
Contributor Author

Try changing regression.yml to compile with Mutation and we'll see if we need to update the docker images.

True. I know there was (maybe still is) an issue with CoDi and MPP...not completely sure.

meson.build Outdated Show resolved Hide resolved
@WallyMaier
Copy link
Contributor Author

@pcarruscag It looks likes Mutation++ has some warnings/errors. I am not sure how to only turn off the return-type warning->error workflow.

@pcarruscag
Copy link
Member

Now you need to set the environment variables to pickup mutation in this script https://github.com/su2code/Docker-Builds/blob/master/test/runTests.sh via PR to the Docker-Builds repo.

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot removed the stale label Jul 15, 2023
@pcarruscag pcarruscag changed the title Update Mutation++ Version Compile SU2 with Mutation++ for regression tests Aug 20, 2023
@pcarruscag
Copy link
Member

I'll change the scope of this for now to just allowing tests to run with mutation++
The NEMO group can add tests and decide whether to update the version later.

@pcarruscag pcarruscag merged commit b7c1577 into develop Aug 20, 2023
31 checks passed
@pcarruscag pcarruscag deleted the feature_update_mpp branch August 20, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants