Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

第二章修改提交 #17

Closed

Conversation

JamesLiAndroid
Copy link
Contributor

@JamesLiAndroid JamesLiAndroid commented Mar 15, 2017

提交信息会对应issue16

@subaochen
Copy link
Owner

看一下File Changed,有22个文件被修改,里面包含了*.lyx~备份文件,*.class文件,这些文件是不应该提交的

1. 标记逗号和英文字符结合时存在的排版问题
2. 修复2.2.2开头逗号的问题

2.2.3中‘对象0’更改为‘对象o’

添加例2.6对于subList方法进行半开半闭的解释

修改2.2.7中理解addAll方法时出现的标点符号问题

修复extends单词拼写错误
@JamesLiAndroid
Copy link
Contributor Author

我有个疑问就是,我在提pr的时候,创建了branch后,

selection_085

上述我所修改的内容能否进行合并?我没找到合并的方式,而且中间夹杂着您那边的提交,我暂时想不到好办法来做。难道需要我这边删库重新fork?

@subaochen
Copy link
Owner

subaochen commented Mar 16, 2017

所以,你在提交之前最好执行git pull upstream master,看一下我这边有没有更新和你的本地分支有冲突。当然不执行也是可以的,只要保证没有冲突。如果有冲突,github会检测到的。

你这个提交中的变更,我暂时没有自己去修改,等待你删除哪些多余的文件后合并进来即可。

@subaochen subaochen closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants