Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit dialog comment pane does not follow Eclipse colors #44

Closed
garydgregory opened this issue Jul 19, 2017 · 0 comments
Closed

Commit dialog comment pane does not follow Eclipse colors #44

garydgregory opened this issue Jul 19, 2017 · 0 comments

Comments

@garydgregory
Copy link

The Commit dialog's comment pane does not follow Eclipse colors. Using the dark theme, the comment pane's background is
2017-07-17 12_21_01-commit
white.
selsemore added a commit that referenced this issue Jan 4, 2019
@selsemore
Fix CommitCommentArea so that it respects theme colors
edf6685 
Problem was due to this Eclipse bug:

  https://bugs.eclipse.org/bugs/show_bug.cgi?id=539441

Fortunately, the problem only shows itself if the SourceViewer uses a
ruler.  CommitCommentArea applied a ruler to the SourceViewer, but it
was unnecessary (this is not related to the ruler that can be made to
show using the 'tsvn:logwidthmarker' property; that works with or
without applying a ruler to the SourceViewer).

Besides fixing Issue #44 (Commit dialog comment pane) and Issue #45 (Set
commit properties dialog), this fixes many other dialogs and wizards
that make use of CommitCommentArea.

Issue #44
Issue #45
@selsemore selsemore mentioned this issue Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garydgregory @selsemore