NPE in ConfigurableMergeAction#selectionChanged

[jhonnen]

With subclipse 4.2.7 and eclipse 4.9 the following NPE occurs sporadically on text selections:

java.lang.NullPointerException
	at org.tigris.subversion.subclipse.ui.internal.TeamAction.selectionChanged(TeamAction.java:256)
	at org.tigris.subversion.subclipse.ui.actions.ConfigurableMergeAction.selectionChanged(ConfigurableMergeAction.java:23)
	at org.eclipse.ui.internal.PluginAction.refreshEnablement(PluginAction.java:209)
	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:276)
	at org.eclipse.ui.internal.PluginAction.selectionChanged(PluginAction.java:300)
	at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyListeners(SelectionService.java:242)

The exception is thrown because getTargetPart().getSite().getPage() returns null. The action's target part is a disposed editor. The PartSite of disposed parts no longer has a reference to its original workbench page (since eclipse 4.9, see Bug 536677).

ConfigurableMergeAction#setActivePart(IAction, IWorkbenchPart) is apparently never called.

Full stacktrace: stacktrace.log

[Marco-Sulla]

I have the same problems. This is fixed in what version of Subclipse?

[Marco-Sulla]

Please, can you answer me? This bug bothers me a lot. I have Subclipse 4.3.0.201901172050 with Eclipse 20190314-1200, on Lubuntu 18.04.2 64 bit. I'm using Java Azul Zulu 8.

[Marco-Sulla]

Hello?

[markphip]

The fix committed in this issue would be included in the 4.3.0 release. Open a new issue with the new stack trace and if possible add a PR with the fix.

[Marco-Sulla]

4.3.0 release is out. So the fix is included?

And PR stands for...?

[markphip]

PR stands for Pull Request