feat: Fix nightly builds and add to CI. (#690)

.github/workflows/run_test_suite.yaml

@@ -39,33 +39,45 @@ jobs:
 
   run-linting-linux:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - toolchain: stable
+          - toolchain: nightly
     steps:
       - uses: actions/checkout@v3
       - uses: Swatinem/rust-cache@v2
       - name: 'Setup Rust'
         run: |
           curl -sSf https://sh.rustup.rs | sh -s -- -y
-          rustup component add clippy
-          rustup component add rustfmt
+          rustup toolchain install ${{matrix.toolchain}}
+          rustup +${{matrix.toolchain}} component add clippy
+          rustup +${{matrix.toolchain}} component add rustfmt
       - name: 'Install environment packages'
         run: |
           sudo apt-get update -qqy
           sudo apt-get install jq protobuf-compiler cmake
       - name: 'Check Format'
-        run: cargo fmt --all -- --check
+        run: cargo +${{matrix.toolchain}} fmt --all -- --check
       - name: 'Run Linter'
-        run: cargo clippy --all -- -D warnings
+        run: cargo +${{matrix.toolchain}} clippy --all -- -D warnings
 
   run-rust-test-suite:
     name: 'Run Rust test suite'
     strategy:
       matrix:
         features: ['test-kubo,headers', 'test-kubo,headers,rocksdb']
         platform: ['ubuntu-latest', 'windows-latest', 'macos-13']
-        toolchain: ['stable']
+        toolchain: ['stable', 'nightly']
         exclude:
           - platform: 'windows-latest'
             features: 'test-kubo,headers,rocksdb'
+          - platform: 'macos-13'
+            toolchain: 'nightly'
+          - platform: 'windows-latest'
+            toolchain: 'nightly'
+          - features: 'test-kubo,headers,rocksdb'
+            toolchain: 'nightly'
     runs-on: ${{ matrix.platform }}
     steps:
       - uses: actions/checkout@v3

rust/noosphere-gateway/src/handlers/v0alpha2/push.rs

@@ -50,7 +50,7 @@ pub async fn push_route<C, S>(
     stream: BodyStream,
 ) -> Result<StreamBody<impl Stream<Item = Result<Bytes, std::io::Error>>>, GatewayErrorResponse>
 where
-    C: HasMutableSphereContext<S>,
+    for<'a> C: HasMutableSphereContext<S> + 'a,
     S: Storage + 'static,
 {
     debug!("Invoking push route...");

rust/noosphere-ns/src/bin/orb-ns/main.rs

@@ -14,12 +14,10 @@ mod utils;
 
 #[cfg(not(target_arch = "wasm32"))]
 mod inner {
-    pub use crate::cli;
     pub use anyhow::{anyhow, Result};
-    pub use noosphere::key::{InsecureKeyStorage, KeyStorage};
+    pub use noosphere::key::InsecureKeyStorage;
     pub use noosphere_core::tracing::initialize_tracing;
     pub use tokio;
-    pub use tracing::*;
 }
 
 #[cfg(not(target_arch = "wasm32"))]

rust/noosphere/Cargo.toml

@@ -73,7 +73,7 @@ features = [
 ]
 
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-safer-ffi = { version = "0.1.2", features = ["proc_macros", "python-headers"] }
+safer-ffi = { version = "0.1.4", features = ["proc_macros", "python-headers"] }
 tokio = { workspace = true, features = ["full"] }
 
 [target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies]

rust/noosphere/build.rs

@@ -1,6 +1,8 @@
 use cfg_aliases::cfg_aliases;
 
 fn main() {
+    println!("cargo:rerun-if-changed=build.rs");
+
     cfg_aliases! {
         // Platforms
         wasm: { target_arch = "wasm32" },

rust/noosphere/src/ffi/mod.rs

@@ -1,7 +1,4 @@
-// TODO(getditto/safer_ffi#181): Re-enable this lint
-#![allow(clippy::incorrect_clone_impl_on_copy_type, non_snake_case)]
-
-//! This module defins a C FFI for Noosphere, suitable for cross-language
+//! This module defines a C FFI for Noosphere, suitable for cross-language
 //! embedding on many different targets
 
 mod authority;