Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Periodic syndication checks to IPFS Kubo #685

Merged
merged 5 commits into from
Oct 30, 2023
Merged

feat: Periodic syndication checks to IPFS Kubo #685

merged 5 commits into from
Oct 30, 2023

Conversation

cdata
Copy link
Collaborator

@cdata cdata commented Oct 18, 2023 •
edited
Loading

  • Adds an automatic attempt by the gateway to syndicate to Kubo at startup and on a 5 minute interval
  • Moves CI tests to cargo-nextest with --retries 5 for relatively lenient flake allowance
  • Makes logging in orb more verbose
  • Rust test suite coverage expanded to include MacOS 13

We now have a Github Workflow that reports test flakes in test runs. The report looks like this:
image

@cdata cdata force-pushed the feat/periodic-syndication branch 2 times, most recently from 17c9a65 to 61a1389 Compare October 23, 2023 16:55
@cdata cdata changed the title Periodic syndication checks to IPFS Kubo feat: Periodic syndication checks to IPFS Kubo Oct 23, 2023
@cdata cdata force-pushed the feat/periodic-syndication branch 8 times, most recently from 1adba02 to 2eabbe7 Compare October 23, 2023 22:07
@cdata cdata force-pushed the feat/periodic-syndication branch 10 times, most recently from 28c2efb to a52cbb2 Compare October 24, 2023 23:15
@subconsciousnetwork subconsciousnetwork deleted a comment from github-actions bot Oct 24, 2023
@subconsciousnetwork subconsciousnetwork deleted a comment from github-actions bot Oct 24, 2023
@subconsciousnetwork subconsciousnetwork deleted a comment from github-actions bot Oct 24, 2023
@subconsciousnetwork subconsciousnetwork deleted a comment from github-actions bot Oct 24, 2023
@cdata cdata force-pushed the feat/periodic-syndication branch 14 times, most recently from 9be0f1a to 4344c71 Compare October 26, 2023 00:08
@cdata cdata marked this pull request as ready for review October 30, 2023 23:29
@cdata cdata requested a review from jsantell October 30, 2023 23:29
jsantell
jsantell approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jsantell jsantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, this should quiet up some tests while still surfacing issues

.github/workflows/run_test_suite.yaml Show resolved Hide resolved
@cdata cdata merged commit b5640b2 into main Oct 30, 2023
20 checks passed
@cdata cdata deleted the feat/periodic-syndication branch October 30, 2023 23:58
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
Merged
This was referenced Oct 31, 2023
Merged
Closed
jsantell pushed a commit that referenced this pull request Oct 31, 2023
@cdata @jsantell
feat: Periodic syndication checks to IPFS Kubo (#685)
6045a61
This was referenced Oct 31, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsantell jsantell jsantell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdata @jsantell