Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Autofill bugs - list of sites that don't work. #197

Open
FoxP opened this issue Jul 23, 2018 · 12 comments
Open

Autofill bugs - list of sites that don't work. #197

FoxP opened this issue Jul 23, 2018 · 12 comments
Labels
bug help wanted QA: UAT Case A good test case for User Acceptance Test
Projects
Milestone

Comments

@FoxP
Copy link

FoxP commented Jul 23, 2018

This issue is a

bug report

Please describe the current behavior, and explain why it's bad.

Some websites like this one need fake keyboard key press for login.

Exemple :

If i use Tusk, the website complains that the login should contain 13 chars.
If i manually add a char and delete it from the login input area, it works.

Please describe how you think it should change.

Tusk should add a "simulate keyboard key press" setting.

Anything else?

Thanks for Tusk, it rocks ! 👍

@zmilonas
Copy link
Collaborator

Hi @FoxP thanks for using Tusk and praising it.

@subdavis may be more knowledgeable on this issue but autofill already sends multiple keyboard events to mock some validations.

In the background/inject.js file:

        function fillField(field, val) {
		field.value = val;
		var filled = (field.value === val);
		sendKeyEvent(field);
		return filled;
	}

	function sendKeyEvent(field) {
		field.focus();

		var eventsToFire = {
			keydown: 'KeyboardEvent',
			keyup  : 'KeyboardEvent',
			change : 'HTMLEvents',
		};

		window.setTimeout(function() {
			for (var i in eventsToFire) {
				var evt = document.createEvent(eventsToFire[i]);
				evt.initEvent(i, true, true);
				field.dispatchEvent(evt);
			}
		});
	}

Of course you're bug report is totally valid since these events as you discovered do not cover all possible websites. Probably @subdavis or I will look into how to improve this and make mega.co.nz and similar autofillable.

@FoxP
Copy link
Author

FoxP commented Jul 23, 2018

Hi @zmilonas, thanks for your answer.
I forgot to tell that i am using Google Chrome 67 on Windows 8.1 with uBlock Origin and Privacy Badger.
Don't hesitate to ask for tests, I would be happy to help!

@FoxP FoxP changed the title Improvement : fake keyboard key press Autofill improvements Jul 23, 2018
@FoxP
Copy link
Author

FoxP commented Jul 23, 2018

Some examples websites also having autofill issues:

@zmilonas
Copy link
Collaborator

My findings

@subdavis subdavis changed the title Autofill improvements Autofill bugs - list of sites that don't work. Jul 23, 2018
@FoxP
Copy link
Author

FoxP commented Jul 24, 2018

This one only has password filled, not login : https://my.pcloud.com/#page=login

@zmilonas
Copy link
Collaborator

zmilonas commented Jul 25, 2018

For future reference I'm also going to link other autofill implementations from different extensions:
https://github.com/browserpass/browserpass/blob/master/chrome/inject.js
https://github.com/bitwarden/browser/blob/master/src/content/autofill.js

I'll try to start working on this autofill improvements this week

@fecchan
Copy link

fecchan commented Aug 25, 2018

I would like to add some other sites that don't work:

I'll report more as soon as I remember more of the sites that don't work.

@dygordon
Copy link

dygordon commented Aug 31, 2018

Another two for me, common banking/investing apps in Canada:

Adding some more:

@zmilonas zmilonas added the QA: UAT Case A good test case for User Acceptance Test label Sep 14, 2018
@zmilonas
Copy link
Collaborator

zmilonas commented Sep 23, 2018

We have an excellent suggestion from @fmunch on what exactly breaks the autofill in some of the sites:

The problem comes from the hidden inputs sitting between the username and password fields in the form, making them not adjacent.

The inputPattern in inject.js does not seem to be used anymore since 4d856b1, hence the hidden inputs not being filtered.

Per #245

@zmilonas
Copy link
Collaborator

zmilonas commented Sep 23, 2018

Also seems like 4d856b1 introduced a regression. We definitely need to work on better testing especially in autofill territory. @subdavis

@subdavis subdavis added this to Backlog in Tusk 2019 Nov 19, 2018
@subdavis subdavis added this to the Tusk 2019 milestone Nov 19, 2018
Repository owner deleted a comment from SuppleForeskin Mar 17, 2019
@FoxP
Copy link
Author

FoxP commented Aug 27, 2019

Another autofill bugged website :

https://www.airbnb.fr/

@jcklie
Copy link

jcklie commented Sep 17, 2019

https://habitica.com/login also does not work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug help wanted QA: UAT Case A good test case for User Acceptance Test
Projects
Tusk 2019
  
Backlog
Development

No branches or pull requests

6 participants