New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate a few deprecated methods to reduce build warnings #67
Migrate a few deprecated methods to reduce build warnings #67
Conversation
…d +alertWithMessageText:defaultButton:alternateButton:otherButton:informativeTextWithFormat:. Reviewed by @tolmasky.
…precated +alertWithMessageText:defaultButton:alternateButton:otherButton:informativeTextWithFormat:. Reviewed by @tolmasky.
…onger use deprecated -beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:. Reviewed by @tolmasky.
…eger and unsigned to NSUInteger). Reviewed by @tolmasky.
…t: in FindReplaceController to no longer use deprecated -beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:. Reviewed by @tolmasky.
…ext:replacementRange:. Reviewed by @tolmasky.
379745c
to
fa56ba8
Compare
I have gone ahead and replaced all the instances of -insertText: with -insertText:replacementRange:. There are now only 10 warnings in the SubEthaEdit project, all related to an alert that isn't as trivial to update. |
There were a couple more that were easy, down to 6 warnings. I think I'll stop here for this PR and do the other ones in a separate PR. |
Thanks! Generally speaking I'm not too fond of the NSUInteger for count changes That being said: your fixes all look sound. |
In this PR I've tried to start tackling some of the deprecated methods that are generating a bunch of warnings in XCode. Specifically I've fixed:
This is a partial fix for #66.