New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Urlscan as passive source #148
Conversation
@CaptainFreak Thanks for this Pull request. |
Looks good ? @Ice3man543 |
@CaptainFreak looks okay 👍 I will test it tonight once i am free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CaptainFreak The urlscan api doesn't works that way. What we actually need to do here is make a request to get all the pre-searched urls that contain domain as uber.com
See this - #82 (comment)
Instead what you are doing is submitting a url for scanning, that is not the purpose i think. Can you change this to be that way?
This looks interesting, why isn't it in use yet? |
It isn't complete yet. The pr doesn't works. And the core is somehow messed up. Don't worry, we'll be releasing something way better soon. Sorry for the delay @ZeroDot1 |
@Ice3man543 No problem, many thanks for the information, good luck for the future work. |
Thanks for the pull request, it is added in the latest version. |
This needs a lot of work.
@Ice3man543 @codingo can you please give me a developer setup and testing guide for testing out the new features while adding them. also a simple to-do list of making this a complete PR would be good. as i have noticed, due to such modularity of this project there are multiple places where i will have to make changes to completely plug in the new source. This PR just contains a very initial work for right now.