Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7 beta 9 - not all italic weights are detected. #170

Closed
jastko opened this issue Mar 9, 2024 · 4 comments
Closed

V7 beta 9 - not all italic weights are detected. #170

jastko opened this issue Mar 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jastko
Copy link

jastko commented Mar 9, 2024

Under Linux, all static otf/ttf italic weights( except Regular Italic), aren't properly detected by some KDE applications, such as Konsole - KDE terminal emulator, or Kate - KDE text editor.

mapleitalics.mp4

I think, that fsSelection and macStyle have wrong settings. For example, from ttx decompilation of BoldItalic style:
fsSelection is set to:

        .....
    <achVendID value="SUBF"/>
    <fsSelection value="00000000 10100000"/>
    <usFirstCharIndex value="0"/>
        .....

and according to the https://learn.microsoft.com/en-us/typography/opentype/spec/os2#fsselection, it should be:

<fsSelection value="00000000 10100001"/>

macStyle has a value of:

        .....
    <yMax value="1120"/>
    <macStyle value="00000000 00000001"/>
    <lowestRecPPEM value="6"/>
        .....

and should have:
<macStyle value="00000000 00000011"/>

After the change, everything works.

By the way, nice font, great work.

@subframe7536 subframe7536 added good first issue bug Something isn't working labels Mar 10, 2024
@subframe7536
Copy link
Owner

subframe7536 commented Mar 10, 2024

Thanks for your detailed suggestion! This issue will be fixed in v7-beta10

@subframe7536
Copy link
Owner

This is caused by the generation of static fonts. But the NerdFont-patched version re-fix it.

@subframe7536
Copy link
Owner

release in v7-beta10

@jastko
Copy link
Author

jastko commented Mar 17, 2024

fixed, thanks

@jastko jastko closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants