Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] V7 Beta 10 Font height is abnormal and star symbol (*) is not aligned to center #174

Closed
dragove opened this issue Mar 18, 2024 · 8 comments
Closed

[BUG] V7 Beta 10 Font height is abnormal and star symbol (*) is not aligned to center #174

dragove opened this issue Mar 18, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@dragove
Copy link

dragove commented Mar 18, 2024

The left side of the image is a previous version of Maple Mono SC NF and the right side is Maple Mono NF CN previewed by intellij idea

The new version is higher and the star character is not centered.

image
@subframe7536
Copy link
Owner

subframe7536 commented Mar 18, 2024 •
edited
Loading

Disable ligature

There is a ligature */ for comment

@subframe7536
Copy link
Owner

So /= maybe need to be reimplemented?

@dragove
Copy link
Author

dragove commented Mar 18, 2024

Thanks, I don't know that */ is implemented in the new version.

reimplement /= is better for me, but I don't know if others like this one.

@subframe7536
Copy link
Owner

tbh. */ also exists in V6, but it has lower priority than /=

@subframe7536
Copy link
Owner

I think all the combinations of operator and equal like += -= *= /= &= ^= |= should keep in same style.

@dragove
Copy link
Author

dragove commented Mar 18, 2024

I've tested += -= *= /= &= ^= |= with Jetbrains Mono. /= &= ^= |= have ligature support, but += -= *= don't.

PixPin_2024-03-18_13-34-27

subframe7536 added a commit that referenced this issue Mar 18, 2024
@subframe7536
various improves
e9a0613 
- longer comma tail
- split |= ligature #174
- manually control locl #150
@subframe7536
Copy link
Owner

v7-beta11 will be like
image
|= and ||= have little changes to make | and = center

@subframe7536
Copy link
Owner

release in v7-beta11

@subframe7536 subframe7536 added the bug Something isn't working label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dragove @subframe7536