Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Staff Map View and 'Get Coordinates' Button from Google Maps to Mapbox #1376

Closed
alirsattar opened this issue Jul 16, 2019 · 2 comments
Assignees
Labels
Projects
Milestone

Comments

@alirsattar
Copy link
Contributor

What's Wrong?

  • The Google Maps SDK and API now requires a credit card be provided even to use free tier services, and so the decision was made to research alternatives.
  • Google Maps based mapping features -- geocoding (converting physical street addresses to coordinates for purposes of mapping staff members, and Google Maps generation with staff members as location pins -- were broken or otherwise not in a production-ready state.

Solution

Test Cases

Given When Then Passed?
Coordinate Lookup Button
User with VALID street address info "Look Up Now" button underneath street address info box is clicked Latitude/longitude text input box is populated with correct latitude and longitude for that street address
User with INVALID street address info "Look Up Now" button is pressed User gets a popup 'alert' dialog saying coordinates could not be found, they should verify that address info is correct and record has been properly saved
Staff_Map View Authorizations
User WITH “view_map” session flag (ie. flag is added/removed, user logs out, and site is hard reloaded) Navigates to /control/admin/staff_map.php User is able to view updated Mapbox map
User WITHOUT “view_map” flag (ie. flag is added/removed, user logs out, and site is hard reloaded) Navigates to /control/admin/staff_map.php User is NOT able to view updated Mapbox map, and is presented with “You are not authorized to view this.” message
Mapbox Features
User with VALID coordinates Staff_Map.php map is shown User has a marker at correct latitude-longitude position
User with NO/INVALID info Staff_Map.php map is shown User does not have a marker on the map, and other users’ markers are unaffected
Staff_Map.php view is shown Staff member marker is clicked Popup created inside of Mapbox map, displaying staff member info
Staff_Map.php view is shown Marker is clicked for staff member WITH NO missing info, and popup appears All fields in popup (headshot, full name, position, full address, email, home phone, cell phone, emergency contact name/relationship/phone number) are populated
Staff_Map.php view is shown Marker is clicked for staff member WITH missing info, and popup appears Missing info fields are replaced with “Not on File”
@alirsattar alirsattar added the map label Jul 16, 2019
@alirsattar alirsattar self-assigned this Jul 16, 2019
@alirsattar
Copy link
Contributor Author

This issue is tied to branch 'ali-dev,' up to and including commit ID # ae79a48.

Link: ae79a48

@alirsattar alirsattar added this to the SP4 Final milestone Jul 19, 2019
@cgb37
Copy link
Contributor

cgb37 commented Aug 6, 2019

Done

@cgb37 cgb37 closed this as completed Aug 6, 2019
@cgb37 cgb37 added this to Done in SP4 Final via automation Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
SP4 Final
  
Done
Development

No branches or pull requests

2 participants