Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS] !important mark not being autocompleted anymore #2905

Closed
gm-style opened this issue Jul 15, 2021 · 0 comments · Fixed by #2907
Closed

[CSS] !important mark not being autocompleted anymore #2905

gm-style opened this issue Jul 15, 2021 · 0 comments · Fixed by #2907
Labels
T: enhancement Improvement of existing language features

Comments

@gm-style
Copy link

  • Sublime Version: 4113
  • OS Version: win 10

Expected behavior

Before version 4, in CSS compiling, there was a working "!important" autocomplete writing

Actual behavior

After version 4 it's not possible anymore add "!important" autocompleting the rule. That's pretty annoying even if it's just a small/rare part of writing in CSS, expecially considering it was working before the version upgrade.

Steps to reproduce

  1. create a CSS with some rules. Try add the "!important" tag
  2. write just the first 2-3 charachters (like: "!im") and TAB to autocomplete

P.S.: it's not an issue related to a missing "!important" string in the document (ex. when it's the first one to be inserted).
deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Jul 15, 2021
@deathaxe
[CSS] Add !important property value completion
6b0edd6 
Fixes sublimehq#2905

Due to ST4's new completion engine various tokens are no longer picked
up from buffer. Words which have been available as "word completions"
before no longer appear.

Effected are all completions which do not start or end with letters or
numbers.

This commit therefore adds `!important` to the list of property values
in css_completions.py to bring them back for users.
@deathaxe deathaxe mentioned this issue Jul 15, 2021
Merged
@deathaxe deathaxe added the T: enhancement Improvement of existing language features label Aug 19, 2021
@deathaxe deathaxe mentioned this issue Aug 27, 2021
Closed
jfcherng pushed a commit that referenced this issue Aug 27, 2021
@deathaxe
[CSS] Add !important property value completion (#2907)
19a5e20 
* [CSS] Add !important property value completion

Fixes #2905

Due to ST4's new completion engine various tokens are no longer picked
up from buffer. Words which have been available as "word completions"
before no longer appear.

Effected are all completions which do not start or end with letters or
numbers.

This commit therefore adds `!important` to the list of property values
in css_completions.py to bring them back for users.

* [CSS] Remove "all" property value completion

Fixes #2996

* [CSS] Use "keyword" kind info for !important completion
mitranim pushed a commit to mitranim/Packages that referenced this issue Mar 25, 2022
@deathaxe @mitranim
[CSS] Add !important property value completion (sublimehq#2907)
95f0eaa 
* [CSS] Add !important property value completion

Fixes sublimehq#2905

Due to ST4's new completion engine various tokens are no longer picked
up from buffer. Words which have been available as "word completions"
before no longer appear.

Effected are all completions which do not start or end with letters or
numbers.

This commit therefore adds `!important` to the list of property values
in css_completions.py to bring them back for users.

* [CSS] Remove "all" property value completion

Fixes sublimehq#2996

* [CSS] Use "keyword" kind info for !important completion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement Improvement of existing language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CSS] Add !important property value completion deathaxe/sublime-packages
2 participants
@gm-style @deathaxe