New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1769] Fix for Clojure code block #1770
Conversation
There was an issue in that the rendering of the Clojure code block in a Markdown file would not be rendered properly. This is documented in Issue sublimehq#1769 - with screen grabs. This addition to the syntax file corrects that issue by adding the section for the Clojure code block in the Markdown file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should have taken a quick look at the other entries in this context instead of just copying what @OdatNurd provided 😉
Indeed! My fix was based on the shipped version of the syntax in the build you mentioned using, which is somewhat different from the version currently in this repo, which has unreleased changes. 😃 |
Co-Authored-By: drbobbeaty <bob@bobbeaty.com>
Co-Authored-By: drbobbeaty <bob@bobbeaty.com>
You guys are right - I should have... I'm terribly sorry about that. |
Please add some syntax test assertions to ensure the changes you made work properly and won't be regressed in the future. https://github.com/sublimehq/Packages#pull-requests
See https://www.sublimetext.com/docs/3/syntax.html#testing for details. |
It makes sense to add a test in the same spirit as the other code block rendering tests, and this is something I pulled from the Clojure syntax test, and adapted to the code block needs. It appears to match the patterns, and the testing requests.
I'm going to hold off on this for now. The Markdown syntax grows in the number of contexts with each syntax we add. We are seeing the sanity limit hit more frequently due to the giant include graph. |
@wbond is there something wrong with the PR that can correct this? Or is it something else that is beyond this PR? |
No, there is nothing wrong with this PR. It is more an issue of us needing to figure out one of:
|
Loading markdown files is already very slow, which makes me doubt an increased sanity limit to be a good solution in manner of performance. |
Since build 4075 we now have embed lazy loads, so this can be merged in without a performance penalty. |
Adds support for Clojure to Markdown fenced code blocks
There was an issue in that the rendering of the Clojure code block in
a Markdown file would not be rendered properly. This is documented in
Issue #1769 - with screen grabs. This addition to the syntax file
corrects that issue by adding the section for the Clojure code block in
the Markdown file.