[Markdown] Add GitHub list checkboxes #2249
Conversation
michaelblyons
force-pushed
the
markdown/checkbox-list
branch
from
8f99799
to
0fec32f
Compare
Markdown/Markdown.sublime-syntax
Outdated
| captures: | ||
| 1: markup.list.unnumbered.markdown | ||
| 2: markup.list.unnumbered.bullet.markdown punctuation.definition.list_item.markdown | ||
| 3: markup.list.unnumbered.markdown | ||
| 4: keyword.other.checkbox.markdown-gfm |
There was a problem hiding this comment.
Random thought while browsing this: What about a storage scope?
There was a problem hiding this comment.
I'd be fine with that.
There was a problem hiding this comment.
Preference for storage.type or storage.modifier?
There was a problem hiding this comment.
Modifier, imo. Actually, now that you mention it it might as well be a language constant. I think I prefer that.
There was a problem hiding this comment.
Modifier, imo. Actually, now that you mention it it might as well be a language constant. I think I prefer that.
Done.
michaelblyons
force-pushed
the
markdown/checkbox-list
branch
from
0fec32f
to
6d6f416
Compare
"Top of the... file?" It already mentions GFM, and to look at the suffix. |
|
True that. I though we had an actual feature list for extensions over commonmark in there, but mentioning GFM is certainly enough to cover checkboxes. 👍 Maybe such a list could be added by @keith-hall later, since he did most of it. |
|
Looks good, thanks for the implementation and reviews! |
Fixes #2248
Unsure on the scope to use, but I like the
.githubtag at the end. In a sense,constant.languageis "right," considering that these represent Booleans, but I didn't think that would go over well.