[Haskell] match (*, @, and #) in keyword.operator.haskell

[moodmosaic]

No description provided.

[michaelblyons]

Have you tried out @FichteFoll's rewrite at #2225? Does that address some of the annoyances you're having?

[moodmosaic]

Wow! I haven't because I wasn't aware of that ❤️ Thank you so much for pointing that out. I'll try it.

[FichteFoll]

I definitely added * but I don't know about @#. Please add comment in that PR and ideally with an example operator, so I can add it.

[moodmosaic]

@michaelblyons, I can definitely open those pull requests also to the branch that targets @FichteFoll's rewrite, which I've just finished reviewing.

Who's taking the final decision to merge that big pull request, though? If there are no plans having that one merged (the rewrite one), I'm not sure it'll make sense to re-target those pull requests(?)

[michaelblyons]

Will Bond is the one who merges PRs to this repo. I can't speak for him, but my observation is that he typically does big batches of merges at once, often before a significant Dev release. Ideally, you want to have your PR all squared away before that window. Because if you miss it, you'll likely languish until the next one.

With that context, Will has specifically said that reviews of PRs help him out. Bear in mind that the maintainer of a repo like this is often merging syntax definitions for languages they do not use, and are correspondingly timid about doing so if a bad PR might upset lots of grumpy developers. If a large Haskell PR has regular Haskell users who vouch for it, it's more likely to make the cut.

That's part of why FichteFoll asked for volunteers to try out #2225. If the author of a PR is not a normal user of the language, some features may be missed when the PR is created.

The two other benefits you have are:

• FF is likely to accept PRs on a prompter timeline.
  • Will's last cycle was Oct/Nov. The next one might be tomorrow, or it might be June. 🤷‍♂
• All the improvements are centralized, so you and others can enjoy them all before they are merged.

[moodmosaic]

@michaelblyons, @FichteFoll, I've opened all pull requests I had on FF's branch. Hope it helps.

[moodmosaic]

I won't be closing those I've opened here, on sublimehq, though. They can be merged if @FichteFoll's pull request never gets merged (which I hope not).

[FichteFoll]

I say it's more likely that my PR gets merged because all of your PRs will conflict with it (and one another, even, because you appended all the tests to the bottom) and I will merge your PRs to my fork once I reviewed them, which is going to happen sooner rather than later.

[moodmosaic]

and I will merge your PRs to my fork once I reviewed them, which is going to happen sooner rather than later

@FichteFoll, yes, as soon as any of those in FichteForks/Packages gets merged or rejected, I'll update these in sublimehq/Packages at the same time.

[moodmosaic]

As per #2272 (comment), closing this since it's merged into #2225. — If #2225 won't get merged into master, I may reopen this.