[CSS] Add custom property completions in var() functions #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST4's auto-completion system no longer picks up custom property names
such as `--my-custom-property` from buffer. Thus they are no longer
suggested in `var(--|)` functions for instance.
This commit extends `css_completions.py` to teach it providing custom
properties defined in current file as completions in `var()` function
arguments.
Example:
html {
--my-custom1: foo;
--my-var2: bar;
}
The following
p {
property: var(--mv|);
}
completes to
p {
property: var(--my-var2|);
}
see: https://forum.sublimetext.com/t/css-variable-suggestions-gone-with-new-update/59431
keith-hall
approved these changes
Jul 17, 2021
jfcherng
approved these changes
Aug 18, 2021
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
) ST4's auto-completion system no longer picks up custom property names such as `--my-custom-property` from buffer. Thus they are no longer suggested in `var(--|)` functions for instance. This commit extends `css_completions.py` to teach it providing custom properties defined in current file as completions in `var()` function arguments. Example: html { --my-custom1: foo; --my-var2: bar; } The following p { property: var(--mv|); } completes to p { property: var(--my-var2|); } see: https://forum.sublimetext.com/t/css-variable-suggestions-gone-with-new-update/59431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ST4's auto-completion system no longer picks up custom property names such as
--my-custom-propertyfrom buffer. Thus they are no longer suggested invar(--|)functions for instance.This PR extends
css_completions.pyto teach it providing custom properties defined in current file as completions invar()function arguments.Example:
With ...
... the following ...
... completes to ...
see: https://forum.sublimetext.com/t/css-variable-suggestions-gone-with-new-update/59431