[Python] Highlight decorators as inline-statements #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of odd `entity.name.function.decorator` scope and instead applies a meta scope to the entire decorator construct that can be highlighed with a background color or fontStyle instead.
Regression introduced by fc77d02.
|
This looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR more appropriately matches decorators as "inline statements" and the
@character as the designating keyword. It also gets rid of the oddentity.name.function.decoratorscope (which is semantically something different) and instead applies a meta scope to the entire decorator construct, not just the initial identifier like before.Before:
After:
(for Monokai, imagine both class names and decorators being green)