New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Matlab] Fixed the block comment scope for the Matlab syntax #650
Conversation
@@ -62,7 +62,7 @@ contexts: | |||
scope: comment.double.percentage.matlab | |||
captures: | |||
1: punctuation.definition.comment.matlab | |||
- match: '%\{' | |||
- match: '%\{\s*\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex should be (%\{)\s*\n
, so that the punctuation
scope is applied to the %{
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though not changed by you, the match
on line 72 should have ()
around the %\}
also.
Updated. |
We should probably also add support for these block comments to https://github.com/sublimehq/Packages/blob/master/Matlab/Miscellaneous.tmPreferences#L35-L40. |
Added. |
Thanks for these fixes! |
you are welcome. However there is bug I forgot to go after before. Here:
It is obligatory a new line to be inserted, otherwise the the block comment does not work. How could a new line to be inserted? There is also a missing new line on the opening and the closing does also need new lines:
I am gonna try:
Take care also when inserting the new files for The SyntaxThe syntax also need to be fixed to not allow anything than spaces/tabs, before and after the symbols |
Fixed the block comment scope for the Matlab syntax
Originaly pointed out on:
Tests results after this work: